Add isolated PHP highlighting with optional HTML support - #18
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a standalone PHP definition for documentation snippets and tagged PHP/HTML documents. It handles PHP tags, attributes, comments, variables, members, strings, heredocs, and nowdocs. Surrounding HTML is highlighted only when HTML is registered.
Adds language exports, fixtures, targeted regressions, a selective size profile, a PHP benchmark, documentation, and a minor changeset.
Validation:
pnpm run verifypasses, including 111 tests. All 334 existing documentation fixtures produce identical results. Four alternating benchmark rounds put existing highlighting at 102–104 ms before and 103–106 ms after, per 10,020 blocks.With Node 24.15.0, PHP adds 990 gzip bytes to the all-language entry after C++/CMake, bringing it to 10,608 bytes. Core stays at 1,820 bytes, TSX at 4,033, and the docs set at 5,971. PHP alone with core is 3,564 gzip bytes. No shared engine changes or runtime dependencies.
Closes #9.