Skip to content

Manage Access Dialog - #872

Merged
SharonStrats merged 9 commits into
stagingfrom
feat/access
Oct 3, 2026
Merged

SharonStrats merged 9 commits into
stagingfrom
feat/access

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Keep in mind this is for the UI structure ticket only, it doesn't work yet.

Also included are some existing web component configuration

  • Combobox needed customized border
  • Input needed a left-slot for search icon
  • Need to hide Label (accessibility) in the input for Search.
    Note: I tried to only configure what I thought were essentials, but you may notice the Copy Link button doesn't match the design, to make it smaller I will need to add configuration for font in the solid-ui-button.
Screenshot 2026-09-27 at 12 12 30 PM

Needs solid-logic changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The save flow is incomplete, and several rendering, accessibility, and integration issues remain.

Review effort: Lite
Findings: 1 High severity · 5 Medium severity · 1 Low severity

Open (7)
What changed in this PR

Adds an access-control sharing dialog with supporting input, combobox, theme, and custom-element updates.

Changes:

  • Adds access-control modal rendering, types, exports, and styles.
  • Adds input left-icon support and configurable borders.
  • Adds combobox border styling and theme color variables.
File Description
src/​types/​custom-elements.d.ts Registers modal element types.
src/​styles/​theme.css Adds theme color variables.
src/​components/​input/​Input.ts Adds left-icon slot support.
src/​components/​input/​Input.styles.css Styles icons and configurable borders.
src/​components/​combobox/​Combobox.styles.css Adds configurable border styling.
src/​components/​access-control-modal/​types.ts Defines access-control types.
src/​components/​access-control-modal/​index.ts Exports the modal component.
src/​components/​access-control-modal/​AccessControlModal.ts Implements the access-control dialog.
src/​components/​access-control-modal/​AccessControlModal.styles.css Styles the dialog UI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/components/access-control-modal/AccessControlModal.ts
Comment thread src/components/access-control-modal/AccessControlModal.styles.css Outdated
Comment thread src/components/access-control-modal/AccessControlModal.ts Outdated
Comment thread src/components/access-control-modal/AccessControlModal.ts
Comment thread src/components/access-control-modal/AccessControlModal.ts
Comment thread src/components/access-control-modal/AccessControlModal.ts
Comment thread src/components/access-control-modal/AccessControlModal.ts Outdated

@NoelDeMartin NoelDeMartin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick review I think it's ok, the only comment is that maybe we shouldn't customize the design system components unless we have a good reason to do it.

Comment thread src/components/combobox/Combobox.styles.css
Comment thread src/lib/components/form-control-component/FormControlComponent.ts Outdated
@SharonStrats SharonStrats changed the title Maange Access Dialog Manage Access Dialog Oct 2, 2026
@SharonStrats
SharonStrats merged commit 0569252 into staging Oct 3, 2026
9 checks passed
@SharonStrats
SharonStrats deleted the feat/access branch October 3, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Sharing pane - overall pane card/structure

3 participants