Manage Access Dialog - #872
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The save flow is incomplete, and several rendering, accessibility, and integration issues remain.
Review effort: Lite
Findings: 1
Open (7)
Save handler discards changes and leaves submitting state active · New Globe icon selector targets the wrong custom element · New Component imports utility through package root, causing bundle coupling · New Missing import prevents globe icon custom element registration · New Origin class subjects are missing from access holder rendering · New Search control lacks an accessible label · New Empty subject URI produces an incomplete dialog title · New
What changed in this PR
Adds an access-control sharing dialog with supporting input, combobox, theme, and custom-element updates.
Changes:
- Adds access-control modal rendering, types, exports, and styles.
- Adds input left-icon support and configurable borders.
- Adds combobox border styling and theme color variables.
| File | Description |
|---|---|
src/types/custom-elements.d.ts |
Registers modal element types. |
src/styles/theme.css |
Adds theme color variables. |
src/components/input/Input.ts |
Adds left-icon slot support. |
src/components/input/Input.styles.css |
Styles icons and configurable borders. |
src/components/combobox/Combobox.styles.css |
Adds configurable border styling. |
src/components/access-control-modal/types.ts |
Defines access-control types. |
src/components/access-control-modal/index.ts |
Exports the modal component. |
src/components/access-control-modal/AccessControlModal.ts |
Implements the access-control dialog. |
src/components/access-control-modal/AccessControlModal.styles.css |
Styles the dialog UI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SharonStrats
force-pushed
the
feat/access
branch
from
September 27, 2026 02:05
aef29ff to
d74eb3d
Compare
NoelDeMartin
approved these changes
Sep 27, 2026
NoelDeMartin
left a comment
Member
There was a problem hiding this comment.
After a quick review I think it's ok, the only comment is that maybe we shouldn't customize the design system components unless we have a good reason to do it.
SharonStrats
force-pushed
the
feat/access
branch
from
October 2, 2026 22:15
5d501fe to
45441d4
Compare
…6.0.0 pane-registry@5.0.1)
…6.0.0 pane-registry@5.0.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Keep in mind this is for the UI structure ticket only, it doesn't work yet.
Also included are some existing web component configuration
Note: I tried to only configure what I thought were essentials, but you may notice the Copy Link button doesn't match the design, to make it smaller I will need to add configuration for font in the solid-ui-button.
Needs solid-logic changes.