Skip to content

CHAD-17872 - changes device category in zigbee-power-meter device profiles - #2846

Open
KKlimczukS wants to merge 7 commits into
mainfrom
CHAD-17872
Open

KKlimczukS wants to merge 7 commits into
mainfrom
CHAD-17872

Conversation

@KKlimczukS

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • X] I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

CHAD-17872 / to meet this policy:
https://developer.smartthings.com/docs/certification/test-suite#supported-device-types

Summary of Completed Tests

@github-actions

github-actions Bot commented Mar 24, 2026 •

Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Mar 24, 2026 •

Copy link
Copy Markdown

Test Results

   73 files    541 suites   0s ⏱️
3 276 tests 3 276 ✅ 0 💤 0 ❌
5 265 runs  5 265 ✅ 0 💤 0 ❌

Results for commit 3db5724.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Mar 24, 2026 •

Copy link
Copy Markdown

File Coverage
All files 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/configurations.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua 93% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against efabd34

@KKlimczukS
KKlimczukS requested a review from cbaumler May 12, 2026 12:57
- id: voltageMeasurement
version: 1
categories:
- name: CurbPowerMeter No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add a trailing newline at EOF here and in the other touched profile YAML files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbaumler fixed

@cbaumler
cbaumler requested a review from hcarter-775 May 12, 2026 19:18

@nand-nor nand-nor left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @cbaumler 's note about adding newlines, this looks good to me. Seems like there is a CI bug that we need to fix but it does not appear to be due to the PR contents

edit: the CI error is expected when profiles are deleted so not technically a bug. In general profile deletions are not expected but it does seem it is expected in this PRs case

@nand-nor

Copy link
Copy Markdown
Contributor

@KKlimczukS Ive merged an update to the CI to address this failure if you want to rebase on main

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

Profile category check: ✅ Passed - all profiles have a category defined.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

zigbee-power-meter_coverage.xml

File Coverage
All files 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/configurations.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua 93% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 3db5724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants