-
Notifications
You must be signed in to change notification settings - Fork 24
fix(aggregation): Use Gramian dtype in AlignedMTL rank tolerance #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SajalDevX
wants to merge
1
commit into
SimplexLab:main
Choose a base branch
from
SajalDevX:fix-aligned-mtl-tolerance-dtype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make this test agnostic of the dtype (i.e. rename it test_smal_eigenvalue_is_kept, and not use dtype=torch.float64). One of our CI runs uses dtype float64, so it will be tested on both float32 and float64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I tried that, but a dtype-agnostic version doesn't catch the bug: it only shows when the matrix dtype differs from torch's default dtype, because
torch.finfo()falls back to the default. With the default dtype, the old and new tolerances are identical, so the test would also pass on main (in the float64 CI run the default is float64 too). That's why the matrix is explicitlyfloat64: under the float32 run it reproduces the bug, and under the float64 run it is just a normal case. I could rename it totest_small_eigenvalue_is_kept_for_non_default_dtypeto make that clearer. Would that work for you?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When our CI runs with
PYTEST_TORCH_DTYPE=float64, it doesn't change torch's default dtype. It just makestensor_(and many other functions, defined intests/utils/tensors.py) implicitly usedtype=float64. Seetests/settings.py. So I don't think the float64 CI run is supposed to pass on main. Are you sure it does pass?