Skip to content

fix stack alignment to 8 bytes for ARM AAPCS compliance - #11841

Open
avm1234567 wants to merge 1 commit into
RT-Thread:masterfrom
avm1234567:fix/stm32-stack-align-8
Open

avm1234567 wants to merge 1 commit into
RT-Thread:masterfrom
avm1234567:fix/stm32-stack-align-8

Conversation

@avm1234567

Copy link
Copy Markdown

Summary

Fixes stack alignment issue for STM32 targets to comply with ARM AAPCS (Issue #7527).

The .stack section in STM32 linker scripts was incorrectly aligned to 4 bytes. According to the ARM Procedure Call
Standard , the stack pointer (SP) must be 8-byte aligned at public function boundaries.

This PR changes ALIGN(4) to ALIGN(8) in the .stack section for all affected STM32 BSP linker scripts and templates.

Changes

  • Changed ALIGN(4) to ALIGN(8) exclusively in the .stack section for exactly 110 STM32 linker scripts (12 templates,
    98 boards).
  • Preserves all board-specific ROM/RAM memory layouts and origins

Files Changed

Templates (12):

  • bsp/stm32/libraries/templates/stm32f0xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f10x/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f2xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f3xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f4xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f7xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32h7xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32l1xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32l4xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32l5xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32mp1xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32wbxx/board/linker_scripts/link.lds

BSP Boards (98):

All 98 remaining link.lds files across bsp/stm32/stm32*/board/linker_scripts/link.lds that contained ALIGN(4) in
the .stack section.

@CLAassistant

CLAassistant commented Sep 27, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix/stm32-stack-align-8
    Enter PR branch fix/stm32-stack-align-8 in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 fix/stm32-stack-align-8 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/stm32-stack-align-8 branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/templates/stm32f0xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f10x/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f2xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f3xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f4xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32f7xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32h7xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32l1xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32l4xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32l5xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32mp1xx/board/linker_scripts/link.lds
  • bsp/stm32/libraries/templates/stm32wbxx/board/linker_scripts/link.lds
  • bsp/stm32/stm32f072-st-nucleo/board/linker_scripts/link.lds
  • bsp/stm32/stm32f091-st-nucleo/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-100ask-mini/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-100ask-pro/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-atk-nano/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-atk-warshipv3/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-blue-pill/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-dofly-M3S/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-dofly-lyc8/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-fire-arbitrary/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-gizwits-gokitv21/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-hw100k-ibox/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-keysking-learning/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-onenet-nbiot/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-yf-ufun/board/linker_scripts/link.lds
  • bsp/stm32/stm32f103-ys-f1pro/board/linker_scripts/link.lds
  • bsp/stm32/stm32f107-uc-eval/board/linker_scripts/link.lds
  • bsp/stm32/stm32f207-st-nucleo/board/linker_scripts/link.lds

🏷️ Tag: bsp_stm32f103-blue-pill

Reviewers: @Liang1795

Changed Files (Click to expand)
  • bsp/stm32/stm32f103-blue-pill/board/linker_scripts/link.lds

📊 Current Review Status (Last Updated: 2026-09-27 20:57 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions Bot added BSP: STM32 BSP related with ST/STM32 BSP labels Sep 27, 2026

@wdfk-prog wdfk-prog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown

MemBrowse Memory Report

stm32f407-rt-spark

  • RAM1: .stack +4 B (+0.1%, 5,476 B / 131,072 B, total: 4% used)

stm32l475-atk-pandora-llvm

  • RAM1: .stack +4 B (+0.1%, 4,244 B / 98,304 B, total: 4% used)

@avm1234567
avm1234567 requested a review from wdfk-prog October 4, 2026 06:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants