Skip to content

fix(tui): keep the xhigh effort color distinct from periwinkle plan mode - #371

Merged
elkaix merged 1 commit into
mainfrom
fix/tui-xhigh-color
Oct 3, 2026
Merged

elkaix merged 1 commit into
mainfrom
fix/tui-xhigh-color

Conversation

@elkaix

@elkaix elkaix commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Requirement or Bug

Keep the xhigh effort border distinct from plan mode after #369 made the primary color periwinkle.

Bug Reproduction Steps

On main, pick xhigh effort with Shift-Tab, then turn on /plan. The prompt border is #A78BFA (xhigh) in one case and #B4B8F8 (plan, periwinkle primary) in the other. The two shades are hard to tell apart.

Root Cause

#369 changed primary, and modePlan with it, to periwinkle #B4B8F8. That moved the plan color close to the existing effortXHigh violet. This is a palette fix, not a workaround.

Code Changes

effortXHigh changes from #A78BFA to #D58BF0 (dark) and from #7048B6 to #8E3AA8 (light). The docs table and the unreleased periwinkle changeset are updated. Contrast: light xhigh on white is 6.32:1, dark xhigh on black is 8.78:1.

Behavior Changes and Affected Users

Behavior Before After Who relies on the old behavior Escape hatch
Prompt border at xhigh effort #A78BFA / #7048B6 #D58BF0 / #8E3AA8 none (visual only) custom theme effortXHigh

Affected module: apps/pythinker-code/src/tui/theme/colors.ts. TUI tests: 2896 passed.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue (external PRs: issue must have a maintainer's /approve).
  • I have added tests that prove my feature works. (palette value change; existing contrast tests cover it)
  • The behavior-change table above is complete, and every removed behavior or flipped default is named in the changeset and either has an escape hatch or was explicitly approved by a maintainer in this PR.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: PyModel/pythinker-code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f0d9fcea-128b-4d3b-94e8-a467a49011da
📥 Commits

Reviewing files that changed from the base of the PR and between 359f143 and 1093874.

📒 Files selected for processing (3)
  • .changeset/periwinkle-primary.md
  • apps/pythinker-code/src/tui/theme/colors.ts
  • docs/customization/themes.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 3, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@pymodel/pythinker-code@1093874
npx https://pkg.pr.new/@pymodel/pythinker-code@1093874

commit: 1093874

@elkaix
elkaix merged commit 6a2fe67 into main Oct 3, 2026
27 checks passed
@elkaix
elkaix deleted the fix/tui-xhigh-color branch October 3, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant