Skip to content

test(model_figure): move the missing-state witness off Delaunay.areas_factor - #751

Merged
Jammy2211 merged 1 commit into
mainfrom
feature/workspace-config-cleanup
Sep 27, 2026
Merged

Jammy2211 merged 1 commit into
mainfrom
feature/workspace-config-cleanup

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Summary

PyAutoGalaxy now configures Delaunay.areas_factor as a Constant (0.5) (PyAutoLabs/PyAutoGalaxy#630), so the MGE-pixelized model-figure acceptance case no longer has an unconfigured parameter. This PR updates the witness:

  • areas_factor is now a fixed Constant row — counts 65 fixed / 0 missing (was 64 / 1).
  • The real-class witness of the missing state moves to the same lens model with its regularization swapped for al.reg.CurvatureMask, whose coefficient still has no configured prior (new test).
  • Test helper lens_models.mge_pixelized() takes an optional regularization class.

Part of PyAutoLabs/PyAutoMind#441 (workspace-config-cleanup).

Merge order: merge PyAutoLabs/PyAutoGalaxy#630 first. These tests need the new Galaxy config and will fail against PyAutoGalaxy main until it lands. Workspace PRs (autofit_workspace, autogalaxy_workspace, autolens_workspace, autocti_workspace) follow in the same task.

Heart YELLOW acknowledged by human (reasons: manifest drift: hub organism blurb (organs present) — 7 mismatches; manifest drift: organism-map blocks (generated) — 1 mismatch; manifest drift: workspace checkouts (manifest ↔ disk) — 1 mismatch; release validation stale: source moved since rehearsal (PyAutoFit, PyAutoArray, PyAutoGalaxy, PyAutoLens)).

API Changes

None — internal changes only. (Test-only: the test_autolens/model_figure/lens_models.mge_pixelized helper gains an optional regularization=None kwarg.)

Test Plan

  • test_acceptance_lens.py — MGE-pixelized case: areas_factor fixed Constant, 65 fixed / 0 missing
  • New test__mge__unconfigured_regularization_coefficient_is_missing (CurvatureMask coefficient → missing / ConfigException, one missing, 13 sampled)
  • python -m pytest test_autolens/ — 759 passed (against the PyAutoGalaxy#630 branch)
Full API Changes (for automation & release notes)

Changed Signature

  • test_autolens/model_figure/lens_models.mge_pixelized(regularization=None) — internal test helper; defaults to al.reg.ConstantSplit as before.

Generated by the PyAutoLabs agent workflow.

🤖 Generated with Claude Code

…_factor

PyAutoGalaxy now configures Delaunay.areas_factor as a Constant (0.5), so the
MGE pixelized acceptance case has no unconfigured parameter: areas_factor is
a fixed Constant row, fixed_leaf_slots 64 -> 65, missing 1 -> 0.

The real-class witness of the `missing` state moves to the same lens model
with its regularization swapped for al.reg.CurvatureMask, whose `coefficient`
still has no prior configured (row missing/ConfigException, one missing, 13
sampled, "coefficient · missing" pill). mge_pixelized() takes an optional
regularization class; its docstring is updated.

Refs PyAutoLabs/PyAutoMind#441

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jammy2211
Jammy2211 merged commit 1e6372f into main Sep 27, 2026
3 checks passed
@Jammy2211
Jammy2211 deleted the feature/workspace-config-cleanup branch September 27, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-release PR queued for the next release build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant