fix: avoid redundant Nautilus completion pass - #1652
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nautilus searches that converged with new posterior samples previously performed an unnecessary intermediate result update and a second no-op sampler call. Use Nautilus's convergence return value to finish immediately, and advance finite update budgets using the cumulative likelihood count instead of posterior sample counts. Global limits also stop when a batch overshoots them.
Closes #1651.
API Changes
No argument or signature changes. Converged searches skip the redundant intermediate update; finite update cadence and global limits count likelihood evaluations correctly. No workspace migration is required.
Test Plan
Full API Changes (for automation & release notes)
Changed Behaviour
Nautilus.call_searchfinishes on the sampler's successfulrun()return without an extra update/run cycle, and recognizes batch overshoot of a global likelihood limit.Nautilus.iterations_fromderives cumulative budgets fromSampler.n_like, including the true current call count forNullPathssearches.Migration
Generated by the PyAutoLabs agent workflow.
Heart RED development-only override
After the exact RED reasons were reported, the human authorized this task: "yeah, and then do a $prm". This permits development commit/push/PR and a same-turn merge only after every required CI check passes. It does not authorize a release or bypass a failing check.
Heart RED reasons:
PyAutoFit: 1 commit(s) behind origin;PyAutoLens: 1 commit(s) behind origin. These describe canonical checkouts; this task is based on current PyAutoFit origin/main. Passed branch gates are listed above.