Repository navigation
Conversation
The README usage example references an operation ID that does not exist in the current OpenAPI spec:
```ts
type ListingsResult = OperationResponse<"get_listings_1">;
```
### Verification
Searched `opensea-api.json` for:
* `get_listings_1` — no matches found
* `list_listings_collection_all` — found as the `operationId` for `GET /api/v2/listings/collection/{slug}/all`
The README example therefore uses a stale/invalid operation ID.
### Change
Replace `get_listings_1` with the operation ID currently defined in `opensea-api.json`:
```ts
type ListingsResult = OperationResponse<"list_listings_collection_all">;
```
This keeps the README example consistent with the OpenAPI source of truth.
Collaborator
|
Thanks! Confirmed with a type-check, where This repo is a read-only mirror, so we can't merge here, but we review every PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The README usage example references an operation ID that does not exist in the current OpenAPI spec:
Verification
Searched
opensea-api.jsonfor:get_listings_1— no matches foundlist_listings_collection_all— found as theoperationIdforGET /api/v2/listings/collection/{slug}/allThe README example therefore uses a stale/invalid operation ID.
Solution
Replace
get_listings_1with the operation ID currently defined inopensea-api.json: