Conversation
`scripts/update-spec.mjs` currently runs Biome through `pnpm exec`. The package does not declare `pnpm` as a dependency, while the update workflow is exposed through `npm run update-spec`. On Windows, when `pnpm` is unavailable, the formatting step fails with: `spawnSync pnpm ENOENT` The script continues after this error, leaving `opensea-api.json` unformatted and causing unnecessary formatting noise in the diff. ### Reproduction With `pnpm` unavailable: ```text biome format failed (continuing): spawnSync pnpm ENOENT ``` This resulted in a large formatting diff in `opensea-api.json`: ```text 3966 additions / 1157 deletions ``` ### Change Replace the `pnpm exec` invocation with `npm exec -- biome` in `scripts/update-spec.mjs`. This uses the existing `@biomejs/biome` devDependency and removes the undeclared `pnpm` requirement from the spec update workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scripts/update-spec.mjscurrently runs Biome throughpnpm exec.The package does not declare
pnpmas a dependency, while the update workflow is exposed throughnpm run update-spec. On Windows, whenpnpmis unavailable, the formatting step fails with:spawnSync pnpm ENOENTThe script continues after this error, leaving
opensea-api.jsonunformatted and causing unnecessary formatting noise in the diff.Reproduction
With
pnpmunavailable:This resulted in a large formatting diff in
opensea-api.json:Solution
Replace the
pnpm execinvocation withnpm exec -- biomeinscripts/update-spec.mjs.This uses the existing
@biomejs/biomedevDependency and removes the undeclaredpnpmrequirement from the spec update workflow.