Skip to content

Fix/gr ndsp 658 too many open files in orph check - #166

Merged
stevenhsd merged 3 commits into
release_v010from
fix/gr-ndsp-658-too_many_open_files_in_orph_check
Sep 29, 2026
Merged

stevenhsd merged 3 commits into
release_v010from
fix/gr-ndsp-658-too_many_open_files_in_orph_check

Conversation

@georgeRobertson

@georgeRobertson georgeRobertson commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

TLDR of changes

Add some changes to orphan record check to improve performance. Specifically only checking when the source entity has at least 1 record and caching the tables for the chain of unions that are taking place.

What kind of changes does this PR introduce?

Tick all that apply

  • fix: A bug fix. Correlates with PATCH in SemVer
  • feat: A new feature. Correlates with MINOR in SemVer
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm)
  • ci: Changes to CI configuration files and scripts (example scopes: GitLabCI)

Please check if the PR fulfills these requirements

  • I have read and followed the Contributing guidance
  • Docs have been added / updated
  • Tests and Linting in the CI are passing
  • Changes have been reviewed and approved by a Project Maintainer

… improve performance on orphan checks"

This reverts commit 872972b.
@sonarqubecloud

Copy link
Copy Markdown

@stevenhsd
stevenhsd merged commit a51254d into release_v010 Sep 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants