Feat/save manual foliations - #123
Merged
Merged
Conversation
The pickled model keeps the solved manual foliations, but GeologicalModelManager.manual_foliations was not saved. After a load, Initialize Model cleared the model features and could not build these foliations again. save_state now writes the foliation specs to the JSON state file, and load_state reads them again.
The data manager now watches the layers that the model reads data from (basal contacts, fault traces, structural orientations and the layers of user-added foliations). When one of them changes, the Geological Model tab shows the changed layers and an "Update Model Data" button. The button reads the changed layers again and puts the new data into the features that are already in the model, so the changes made to those features stay (Initialize Model builds every feature again). A changed fault trace, or a group that gets or loses all of its data, cannot go into the current model; the model status then asks for Initialize Model. Initialize Model now also reads the changed layers again before it builds the model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.