Skip to content

build(deps): pin cloud-commitments-go to main (6168f8b) - #2102

Merged
cristim merged 1 commit into
mainfrom
build/pin-cloud-commitments-go-6168f8b
Sep 28, 2026
Merged

cristim merged 1 commit into
mainfrom
build/pin-cloud-commitments-go-6168f8b

Conversation

@cristim

@cristim cristim commented Sep 28, 2026

Copy link
Copy Markdown
Member

Summary

Re-pins github.com/LeanerCloud/cloud-commitments-go/{pkg,providers/aws,providers/azure,providers/gcp} from the abandoned split-PR pseudo-versions to the commit that actually landed on go main.

Why

cloud-commitments-go PR #1 was squash-merged to main as 6168f8b5360d5189c140cd8f4de614531cffa998. This repo's previous pins were pseudo-versions taken from the unmerged split branch before the squash:

Module Old pin New pin
pkg v0.0.0-20260925082912-43ab778da7ac v0.0.0-20260928074610-6168f8b5360d
providers/aws v0.0.0-20260926232454-692cacc627d1 v0.0.0-20260928074610-6168f8b5360d
providers/azure v0.0.0-20260926232454-692cacc627d1 v0.0.0-20260928074610-6168f8b5360d
providers/gcp v0.0.0-20260926232454-692cacc627d1 v0.0.0-20260928074610-6168f8b5360d

Those commits (43ab778da7ac, 692cacc627d1) are no longer reachable from go main after the squash-merge, so this repo's go.mod pointed at history that no longer exists there.

Change

GOWORK=off GOTOOLCHAIN=go1.26.6 go get \
  github.com/LeanerCloud/cloud-commitments-go/pkg@6168f8b5360d5189c140cd8f4de614531cffa998 \
  github.com/LeanerCloud/cloud-commitments-go/providers/aws@6168f8b5360d5189c140cd8f4de614531cffa998 \
  github.com/LeanerCloud/cloud-commitments-go/providers/azure@6168f8b5360d5189c140cd8f4de614531cffa998 \
  github.com/LeanerCloud/cloud-commitments-go/providers/gcp@6168f8b5360d5189c140cd8f4de614531cffa998
go mod tidy

All four modules resolved to v0.0.0-20260928074610-6168f8b5360d (MVS resolved cleanly; the pkg/providers go.mod files inside cloud-commitments-go may still reference older pseudo-versions of each other, but the resulting build graph is consistent). go.work still only contains use ., unchanged.

The renamed exported identifiers in cloud-commitments-go (AWSProvider->Provider, XxxAPI->API, etc.) required no call-site changes here; go build/go vet pass with no errors.

Verification

  • go build -o /dev/null ./cmd: pass
  • go vet ./...: pass (no findings)
  • go test -race -short ./...: pass, ok github.com/LeanerCloud/cloud-commitments-cli/cmd 445.556s (single package, no FAIL)
  • go mod tidy -diff: empty (clean)
  • golangci-lint v2.10.1 (CI-pinned version, golangci-lint run --timeout=10m, exact CI invocation): 0 issues

Closes nothing; this is a housekeeping re-pin, not tied to a specific issue.

The previous pseudo-version pins (pkg@43ab778da, providers/{aws,azure,gcp}@692cacc627d1)
were on the unmerged cloud-commitments-go PR #1 split branch, which no longer exists
on main after the squash-merge to 6168f8b5360d5189c140cd8f4de614531cffa998. Re-pin all
four modules to that commit.
@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 7 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 3 included reviews currently available. Your 41 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 7db72a84-c724-4855-b689-f66d27896510

📥 Commits

Reviewing files that changed from the base of the PR and between 443ebc2 and 9d3d53b.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Comment @coderabbitai help to get the list of available commands.

@cristim cristim added type/chore Maintenance / non-user-visible severity/low Minor harm urgency/this-sprint Within the current sprint impact/internal Team-internal only effort/xs Trivial / one-liner priority/p2 Backlog-worthy triaged Item has been triaged labels Sep 28, 2026
@cristim

cristim commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

Independent review + local verification: MERGE at 9d3d53b. Re-pins cloud-commitments-go to main (6168f8b5); exactly the expected 8 go.sum lines; go mod verify OK; full -race suite passes against the new library (so no renamed identifier is referenced); checks green.

@cristim
cristim merged commit 5036518 into main Sep 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/internal Team-internal only priority/p2 Backlog-worthy severity/low Minor harm triaged Item has been triaged type/chore Maintenance / non-user-visible urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant