Drop unused MbedTLS dependency (0.2.10) - #127
Merged
Merged
Conversation
`src/client.jl` imported MbedTLS but never used it. Remove the import, the `[deps]` entry and its compat bound, and bump to 0.2.10. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
krynju
marked this pull request as ready for review
September 23, 2026 11:14
HTTP.jl 2.7 keeps a `String` body as-is in `HTTP.Response(status, body)`, so `copy(resp.body)` throws a MethodError. Only copy when the body is a byte vector. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
tanmaykm
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/client.jlhasusing MbedTLSbut nothing in the package references it. This removes the import, the[deps]entry and its[compat]bound, and bumps the version to 0.2.10 for a patch release fromrelease-0.2.The 1.x line on
mainalready has no MbedTLS dependency; this brings the 0.2.x line in line so downstream users stop pulling MbedTLS.jl (and MbedTLS_jll) into their manifests.Also fixes a test that broke with HTTP.jl 2.7:
HTTP.Response(status, body::String)now keeps the body as aString, sotest_http_resp'scopy(resp.body)threw aMethodError. The test now only copies when the body is a byte vector. This was failing onrelease-0.2independently of the MbedTLS change (last green run resolved HTTP.jl 2.6.6).Testing
Pkg.test()on Julia 1.12 with HTTP.jl 2.7.1 passes, and MbedTLS is no longer in the resolved manifest.🤖 Generated with Claude Code