Repository navigation
Gate AC_add_package_to_executor behind a package allowlist - #492
Merged
Merged
Conversation
…on list cannot load os or subprocess
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 22 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…s U-20261001-07, renumber the package gate entry to 08
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace X-12:
AC_add_package_to_executor/AC_add_package_to_callback_executorimported any installed package and registered its members as commands, so an action list from a JSON file, the socket / REST / MCP servers or the scheduler could loadosorsubprocess.PackageManagerchecks the name before importing.allow_packages(*names)is an allowlist (submodules included);set_allow_arbitrary_packages(bool)opens or closes the gate for everything else. A refusal raisesAutoControlExecuteActionException, which becomes that action's failure.Executor.allow_packages/Executor.set_allow_arbitrary_packagesare the same switches as static methods. Neither is anAC_*command, so an action list cannot open its own gate (a test checks no command name contains them).DeprecationWarning; flipping the default is recorded inProgress.md.Docs: the three READMEs, the Sphinx package manager and executor pages,
architecture.md§7,architecture_explore.md(counts re-measured withtest_doc_line_counts.py --fix),CHANGELOG.md(Added, Deprecated),docs/updatesU-20261001-07 (03–06 are taken byfeat/jeffrey-rpa-gui-apis).Stacked on
feat/coverage-to-80(#490), which also touchespackage_manager_class.py.Tests:
test/unit_test/headless/test_package_gate.py(8). Full headless suite on this branch: 10559 passed, 46 skipped.