Copy shared/file-download into the computer image, and boot it in CI - #723
Merged
Merged
Conversation
#698 made agent-computer/src/index.ts import ../../shared/file-download at runtime. The computer Dockerfile copies only agent-computer/src, so the image built and then exited on start with "Cannot find module". The other shared imports there are type-only and erased, which is why this one was the first to break. The one file now goes to /shared, where the relative path resolves from /app/src. The component image job only built the Dockerfiles, and a build succeeds with a missing runtime module, so it now also starts the computer image and waits for /health.
davidmckayv
requested review from
MikeRyanDev,
guidovizoso and
tylerslaton
as code owners
October 2, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#698 made
agent-computer/src/index.tsimport../../shared/file-downloadat runtime.agent-computer/Dockerfilecopies onlyagent-computer/src, so the image builds and then exits on start:That breaks
scripts/start.shfor everyone and would publish a brokenopenbot-agent-computerimage at the next release. The other../../sharedimports inagent-computer/srcare type-only and erased, so this is the first runtime one.shared/file-download.ts(no imports of its own) to/shared, where the relative path resolves from/app/src. The all-in-oneDockerfilealready copies all ofshared/./health.Verified locally: main's image exits with the error above; this branch's image answers
/health200. The new CI step fails against main's Dockerfile and passes against this one.