London | 26-Sep-ITP | Frumentius Tesfay | Sprint 1 | Format clock edge cases - #1634
Open
Frumentius-Rev wants to merge 6 commits into
Open
Frumentius-Rev wants to merge 6 commits into
Frumentius-Rev wants to merge 6 commits into
Conversation
Frumentius-Rev
added
the
Needs Review
cjyuan
reviewed
Oct 4, 2026
Contributor
There was a problem hiding this comment.
Could you check whether the expected return values specified in the tests use a consistent format?
When a function's return values are not consistently formatted, it can lead to unintended side effects. For examples:
- When the formatted strings are displayed, they may not align nicely:
01:00 am
1:00 pm
12:00 am
01:00 pm
02:00pm
- When the formatted strings are compared in a program, they may produce unexpected results:
"1:00 pm" < "11:00 pm"evaluates tofalse"01:00 am" < "11:00 am"evaluates totrue
For this reason, it would be better to ensure that the function always returns values in a consistent format.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1197
Changelist
Fixed time conversion for edge cases.
Added tests for different times and conversions.