Cape Town | 26-ITP-Sep | Raees Stevens | Sprint 2 | Coursework/sprint 2 - #1640
Open
RaeesStevens wants to merge 40 commits into
Open
RaeesStevens wants to merge 40 commits into
RaeesStevens wants to merge 40 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
RaeesStevens
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
cjyuan
added
the
Review in progress
cjyuan
reviewed
Oct 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Previously, the validation bot removed the "Needs review" label from this PR because it detected that the PR branch did not follow the CYF convention. Once the PR branch was fixed, the "Needs review" label should have been added again.
Please note that in ITP, trainees need to ensure their PR has the "Needs review" label whenever they expect the PR to be reviewed.
| // Line 1 is a variable declaration, creating the count variable with an initial value of 0 | ||
| // Describe what line 3 is doing, in particular focus on what = is doing | ||
|
|
||
| // = in line 3 is assigning the rule that counting must start at 0. No newline at end of file |
Contributor
There was a problem hiding this comment.
Line 3 does not enforce any "rule that counting must start at 0".
Could you rephrase the description?
| console.log(num); | ||
|
|
||
| // num represents any randomly generated number between 1 and 100. | ||
| // Math.random pulls a random decimal, Math.floor rounds down to nearest whole number, (maximum - minimum + 1) sets the range, adding the minimum of 1 at the end allows for the possibility of a random number being 100 instead of 99. No newline at end of file |
Contributor
There was a problem hiding this comment.
What is the range of the random numbers returned by Math.random()?
Contributor
There was a problem hiding this comment.
Math.random() cannot return 100.
Author
There was a problem hiding this comment.
Apologies, was multi-tasking when I replied. Math.random() range will be 0 - 99. The range of num is 100.
Contributor
There was a problem hiding this comment.
I don't think Math.random() can return 50 or 99 either.
cjyuan
added
Reviewed
RaeesStevens
added
Needs Review
RaeesStevens
added
the
Needs Review
Contributor
|
Changes to the code look good. The answer to the question in this comment is still not correct. |
cjyuan
removed
the
Needs Review
RaeesStevens
added
the
Needs Review
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self Checklist
Task code
CYF-1039
Changelist
Completed Sprint 2 coursework