Cape Town | 26-ITP-September | Sima Nongawuza | Sprint 3 | Coursework/sprint 3 by simanongawuza · Pull Request #1637 · CodeYourFuture/Module-JavaScript-Fundamentals

simanongawuza · 2026-10-02T17:07:32Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist
-Completed all mandatory and stretch tasks for Sprint 3.
-Fixed bugs in the debugging exercises.
-Implemented the toPounds function.
-Added edge case tests for the time format exercise

…matAs12HourClock.

netlify · 2026-10-02T17:07:40Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`6407f1a`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6abfe4d782be5d0008b123f1
😎 Deploy Preview	https://deploy-preview-1637--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hackertainment

Your work generally looks good to me. Just some minor English presentation issues which may affect accuracy or understanding. Most of my comments are just for your future reference and improvement.

You just need to give a reply to the following comments:

And code fix for the following comments:

Thank you for your effort, and keep it up.

hackertainment · 2026-10-04T12:42:10Z


 // =============> write your explanation here
+
+//The code runs but gives undefined in the console when we call the sum(10, 32). The return function is not defined. We must define it a + b so that when we call it, it give the sum of the 2 values


Found a typo and should be "... The return value is not defined..." - because precisely speaking, the sum function itself is defined (in line 4) and the return itself is a built-in function (i.e. defined in JavaScript).

hackertainment · 2026-10-04T12:48:51Z

+// The const variable must be removed from the code. The computer reads that first and gives the same output for all console.log statements.
+// A placeholder variable for num must be declared in the function parameter.


I think line 33 would be a more accurate explanation. For line 32, even the const num variable is kept in the fixed code, the num.toString() in your function would still use the num in function parameter (when they are the same name). This is the concept of "scope of variable" in JavaScript (and other programming languages as well). So the key issue is "whether the function parameter exist or not", but not quite "whether the global constant variable removed or not".

hackertainment · 2026-10-04T12:54:38Z

+//}
+function calculateBMI(weight, height) {
+  squareHieght = height * height;
+  calculateBMI = Math.round(((weight / squareHieght)) *10 )/10;


While your program produce the correct result, the ((weight / squareHieght)) used double brackets. This is not quite recommended - especially in socket programming, single pairs of bracket and double pairs of bracket may yield different results.

hackertainment · 2026-10-04T12:57:24Z

+  const penceStringWithoutTrailingP = penceString.substring(0, penceString.length - 1);
+  const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
+  const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length -2);
+  const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length -2).padEnd(2, "0");


Just to clarify a bit, why .padEnd(2, "0") is needed here?

hackertainment · 2026-10-04T13:05:01Z

+console.log(toPounds("399p"))
+console.log(toPounds("10p"))
+console.log(toPounds("1023p"))
+console.log(toPounds("5p"))


Your program looks generally ok to me. However, have you think of console.log(toPounds("0000000p")); and would it be the output you wanted? Just to give you a thought first and you don't need to fix the issue at this point, because you will learn more about designing test cases in the later module.

hackertainment · 2026-10-04T13:08:59Z

-  const hours = Number(time.slice(0, 2));
-  if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+  const timeString = String(time);


Just wondering why this line is needed?

hackertainment · 2026-10-04T13:12:06Z

-  return `${time} am`;
+  const paddedHours = String(hours).padStart(2, "0");
+  const paddedMinutes = String(minutes).padStart(2, "0");
+  return `${paddedHours}:${paddedMinutes}${period}`;


Based on the original given targetedOutput (which has been deleted in your code), there should be a space before period (e.g. 08:00 am but not 08:00am).

hackertainment · 2026-10-04T13:14:51Z

+console.log(formatAs12HourClock("00:30"))
+console.log(formatAs12HourClock("23:32"))
+console.log(formatAs12HourClock("08:50"))
+console.log(formatAs12HourClock("13:00"))


Your test cases have covered am and pm. However, there are still 3 boundary cases which have not been covered yet. Can you think of them and add them too? Thank you.

simanongawuza added 11 commits September 29, 2026 21:17

Debugged and updated the code.

352f54e

Reemoved hardcoded value and fixed console.log scope

38d9150

corrected the function parameter syntax

7dfcfcd

Added a return to the multiply function

ea78769

Defined the return function of sum to a + b.

9f6a5e5

Removed the const variable and declared num in the function parameter

9b6c0a5

Implemented a BMI calculator.

cffe689

Implemented Uppercase function and replace method to convert strings

c4c22e3

Changed sprint 1, 3-mandatory-interpret to reusable code

a396ade

Understanding of Pad and formatTimeDisplay functions

4a52872

Used IF statements and edge case handling to resolve typeError in for…

6407f1a

…matAs12HourClock.

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

simanongawuza added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 2, 2026

hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2026

hackertainment mentioned this pull request Oct 3, 2026

Get Code Review and Iterate hackertainment/My-Coursework-Planner#8

Open

hackertainment reviewed Oct 4, 2026

View reviewed changes

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 4, 2026

Navigation Menu

Uh oh!

Cape Town | 26-ITP-September | Sima Nongawuza | Sprint 3 | Coursework/sprint 3 - #1637

Cape Town | 26-ITP-September | Sima Nongawuza | Sprint 3 | Coursework/sprint 3#1637
simanongawuza wants to merge 11 commits into
CodeYourFuture:mainfrom
simanongawuza:coursework/sprint-3

simanongawuza commented Oct 2, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Oct 2, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

hackertainment left a comment

Uh oh!

hackertainment Oct 4, 2026

Uh oh!

hackertainment Oct 4, 2026

Uh oh!

hackertainment Oct 4, 2026

Uh oh!

hackertainment Oct 4, 2026

Uh oh!

hackertainment Oct 4, 2026

Uh oh!

hackertainment Oct 4, 2026

Uh oh!

hackertainment Oct 4, 2026

Uh oh!

hackertainment Oct 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		// =============> write your explanation here

		//The code runs but gives undefined in the console when we call the sum(10, 32). The return function is not defined. We must define it a + b so that when we call it, it give the sum of the 2 values

		// The const variable must be removed from the code. The computer reads that first and gives the same output for all console.log statements.
		// A placeholder variable for num must be declared in the function parameter. No newline at end of file

Uh oh!

Conversation

simanongawuza commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task code

Uh oh!

netlify Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

hackertainment left a comment

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

simanongawuza commented Oct 2, 2026 •

edited

Loading

netlify Bot commented Oct 2, 2026 •

edited

Loading

hackertainment Oct 4, 2026 •

edited

Loading