fix(tui): launch lazygit and other cwd-based editors correctly (#23) - #41
Merged
Merged
Conversation
Bare lazygit/gitui/tig now run in the repo dir without a positional path
(lazygit parsed it as a subcommand). Editors support a {path} token, and
every editor starts with cwd set to the repo.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the launch half of #23.
Problem
Editors were run as
<editor> <repo-path>. lazygit parses a positional arg as a subcommand (status,log, …), so it exited withInvalid git arg value: '<path>'.Change
editorArgs/editorCmdininternal/tui/editor.go:{path}token ineditor:is substituted (e.g.lazygit --path {path}).lazygit/gitui/tigget no positional path; they open the repo via cwd.code,nvim, and thelazygit --pathworkaround still work.cmd.Dir= repo.{path}..exepath and the legacy--pathform.Not covered here
ExecProcess. chore(deps): bump the gomod group with 4 updates #38 moved us to bubbletea 1.3.10. Needs reporter confirmation on Windows.shell.Fieldstreats\as escape, soeditor: C:\tools\lazygit.exemay mangle; use forward slashes or a PATH name.Test plan
go test -race ./...,go vet ./...GOOS=windows go build ./...editor: lazygit, Enter on 3 repos in one session (Windows + macOS)🤖 Generated with Claude Code