fix: session-lifecycle, heartbeat, update-check, and settings bugs - #142
Merged
Merged
Conversation
- /copy-session-id: ordering-based awaitSessionConfirm gate so the connect-time placeholder id cannot be copied before the post-prompt session frame confirms the real id; resumed sessions keep copying - /new: one-shot suppressRemember stops the reconnect session frame from re-persisting the placeholder id into workspaces.json - heartbeat: skip ping and pingSentAt stamp while disconnected; reset the stamp on reconnect swap so RTT pairs with the live socket - update: Newer parses the latest tag via pseudoBase so prerelease latest releases no longer read as always up-to-date - settings: refuse persistence for the run when the config file fails to parse instead of overwriting it with a near-empty file
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bodek | 5cb606e | Commit Preview URL Branch Preview URL |
Sep 30 2026, 10:35 AM |
The fake banner carried ?token=cafef00d, so waitSpawned returned as soon as line 1 was scanned — Stop() then closed the pipe while lines 2-3 were still in flight, failing the passthrough assertions on fast runners. The banner now omits the token so the wait ends on the WS token line, which also makes the token assertion prove the WS-token path instead of the banner fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 5 validated bugs from the wave-1 bug hunt, RED-first with regression tests:
/copy-session-idcan no longer copy the connect-time placeholder id during the window before the post-prompt session frame; resumed sessions unaffected/newno longer has its workspace session mapping restored by the reconnect session framebodek upgradeno longer reports prerelease latest releases as always up-to-dateGates: fmt/vet/lint clean,
go test -race ./...green. Adversarially reviewed; review findings addressed.