Skip to content

[ALICE3] Refine pdgCodes and update histogram logic - #18205

Merged
njacazio merged 2 commits into
AliceO2Group:masterfrom
njacazio:master
Oct 8, 2026
Merged

njacazio merged 2 commits into
AliceO2Group:masterfrom
njacazio:master

Conversation

@njacazio

@njacazio njacazio commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Updated pdgCodes to only include 211 and added logic to handle duplicates and include 0. Adjusted histogram configurations and calculations for particle tracking performance.

Updated pdgCodes to only include 211 and added logic to handle duplicates and include 0. Adjusted histogram configurations and calculations for particle tracking performance.
@njacazio
njacazio marked this pull request as ready for review October 7, 2026 16:52
@github-actions github-actions Bot added the alice3 label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 64f6175 at 2026-10-07 19:27:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/ALICE3/Tasks/alice3TrackingPerformance.cxx:80:100: error: narrowing conversion of '((Alice3TrackingPerformance*)this)->Alice3TrackingPerformance::pdgCodes.o2::framework::Configurable<std::vector<int> >::o2::framework::ConfigurablePolicyConst<std::vector<int>, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<std::vector<int>, o2::framework::kGeneric>::o2::framework::ConfigurableBase<std::vector<int>, o2::framework::kGeneric>.o2::framework::ConfigurableBase<std::vector<int>, o2::framework::kGeneric>::value.std::vector<int>::size()' from 'std::vector<int>::size_type' {aka 'long unsigned int'} to 'int' [-Werror=narrowing]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 64f6175 at 2026-10-07 19:31:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/ALICE3/Tasks/alice3TrackingPerformance.cxx:80:100: error: narrowing conversion of '((Alice3TrackingPerformance*)this)->Alice3TrackingPerformance::pdgCodes.o2::framework::Configurable<std::vector<int> >::o2::framework::ConfigurablePolicyConst<std::vector<int>, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<std::vector<int>, o2::framework::kGeneric>::o2::framework::ConfigurableBase<std::vector<int>, o2::framework::kGeneric>.o2::framework::ConfigurableBase<std::vector<int>, o2::framework::kGeneric>::value.std::vector<int>::size()' from 'std::vector<int>::size_type' {aka 'long unsigned int'} to 'int' [-Werror=narrowing]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 64f6175 at 2026-10-07 22:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 13 warnings.'
Found 4 errors and 13 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/6f481cf8292e0aa9580febac7fc582e5951390d4/O2Physics-code-check/errors.txt
ALICE3/Tasks/alice3TrackingPerformance.cxx:68:10: error: no header providing "std::sort" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Tasks/alice3TrackingPerformance.cxx:69:31: error: no header providing "std::unique" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Tasks/alice3TrackingPerformance.cxx:71:14: error: no header providing "std::find" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Tasks/alice3TrackingPerformance.cxx:80:81: error: non-constant-expression cannot be narrowed from type 'size_type' (aka 'unsigned long') to 'int' in initializer list [clang-diagnostic-c++11-narrowing]
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/6f481cf8292e0aa9580febac7fc582e5951390d4/O2Physics-code-check/warnings.txt
ALICE3/Tasks/alice3TrackingPerformance.cxx:44:22: warning: variable 'particlePdgCodes' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:45:37: warning: variable 'particlePtDistribution' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:46:37: warning: variable 'particleEtaDistribution' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:47:37: warning: variable 'ptDistribution' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:48:37: warning: variable 'ptResolutionVsPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:49:44: warning: variable 'ptResolutionVsEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:50:37: warning: variable 'invPtResolutionVsPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:51:44: warning: variable 'invPtResolutionVsEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:52:37: warning: variable 'dcaXyResolutionVsPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:53:37: warning: variable 'dcaZResolutionVsPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:54:37: warning: variable 'covariancePtPtVsPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:55:37: warning: variable 'covarianceDcaXyDcaXyVsPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/Tasks/alice3TrackingPerformance.cxx:56:37: warning: variable 'covarianceDcaZDcaZVsPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

Updated the initialization of particlePdgCodes and added histogram declarations for various particle distributions.
@github-actions github-actions Bot changed the title Refine pdgCodes and update histogram logic [ALICE3] Refine pdgCodes and update histogram logic Oct 8, 2026
@njacazio
njacazio enabled auto-merge (squash) October 8, 2026 08:15

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio
njacazio merged commit e0d72b9 into AliceO2Group:master Oct 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants