Skip to content

[PWGLF] Fix derived UPC analysis and add Lambda feeddown histograms - #18181

Merged
romainschotter merged 6 commits into
AliceO2Group:masterfrom
nepeivodaRS:str-upc-upd
Oct 6, 2026
Merged

[PWGLF] Fix derived UPC analysis and add Lambda feeddown histograms#18181
romainschotter merged 6 commits into
AliceO2Group:masterfrom
nepeivodaRS:str-upc-upd

Conversation

@nepeivodaRS

@nepeivodaRS nepeivodaRS commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Use each MC candidate’s generator to separate UPC and hadronic contributions, even when its vertex has a different MC label.
Add Lambda and AntiLambda feeddown histograms with gap and mass information, and generated Xi and AntiXi denominators.
Fix cascade charge selection, TOF PID cuts, and pion-to-muon handling in MC.
Fix UPC flag checks and QA histogram filling.

@nepeivodaRS
upd
4d8d327 
classification of the MC candidates by the generator ID (vtx assoc.)
upd feeddown matrix calc.
fix some bugs
@github-actions github-actions Bot added the pwglf label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 62 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Oct 5, 2026
Merged
nepeivodaRS and others added 3 commits October 5, 2026 20:47
@nepeivodaRS
Merge pull request #25 from alibuild/alibot-cleanup-18181
6733279 
Please consider the following formatting changes to AliceO2Group#18181
@nepeivodaRS
[PWGLF] Fix UPC and cascade task lint checks
7427d87 
Remove redundant conditions and initialization, avoid histogram registry shadowing, and mark particle-type branches as compile-time decisions. Suppress cppcheck false positives only on those template comparisons. Restore the MC FT0M centrality join needed by cascqaanalysis.
@nepeivodaRS
adj the reference coll check
5ba7016
@nepeivodaRS
nepeivodaRS marked this pull request as ready for review October 6, 2026 16:42
romainschotter
romainschotter previously approved these changes Oct 6, 2026
View reviewed changes
@romainschotter
romainschotter enabled auto-merge (squash) October 6, 2026 16:51
@alibuild

alibuild commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5ba7016 at 2026-10-06 20:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 230 warnings.'
Found 1 errors and 230 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/83b1e325b55ba2bad4d015526b09543c227e8734/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/derivedupcanalysis.cxx:1444:91: error: no header providing "o2::dataformats::TimeStamp" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 230 -gt 0 ]]
++ cat /sw/BUILD/83b1e325b55ba2bad4d015526b09543c227e8734/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:148:15: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:159:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:176:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:177:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:204:16: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:206:16: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:209:16: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:213:16: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:329:24: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:331:27: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:339:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:344:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:349:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:361:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:375:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:378:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:382:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:385:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:391:138: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:394:163: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:397:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:400:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:403:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:406:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:409:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:412:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:415:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:418:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:421:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:424:103: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:428:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:431:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:435:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:438:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:445:103: warning: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:445:125: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:448:103: warning: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:448:125: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/cascpostprocessing.cxx:452:103: warning: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
[0 more errors; see full log]

Full log here.

auto-merge was automatically disabled October 6, 2026 18:53

Head branch was pushed to by a user without write access

@romainschotter
romainschotter merged commit 2e196f9 into AliceO2Group:master Oct 6, 2026
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romainschotter romainschotter romainschotter approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nepeivodaRS @alibuild @romainschotter