You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Error while checking build/O2Physics/code-check for 203b86a at 2026-10-02 14:10:
## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 22 warnings.'
Found 8 errors and 22 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/7fd0ca22f5cbe02fe99834f7a58c08774394164f/O2Physics-code-check/errors.txt
ALICE3/Core/ConfigurationParser.cxx:98:14: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:105:14: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:125:18: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:132:18: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:141:14: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:149:14: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/ConfigurationParser.cxx:206:12: error: constness of 'localPath' prevents automatic move [performance-no-automatic-move,-warnings-as-errors]
ALICE3/Core/GeometryContainer.cxx:22:1: error: included header BasicCCDBManager.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 22 -gt 0 ]]
++ cat /sw/BUILD/7fd0ca22f5cbe02fe99834f7a58c08774394164f/O2Physics-code-check/warnings.txt
ALICE3/Core/ConfigurationParser.cxx:72:15: warning: use starts_with instead of find [modernize-use-starts-ends-with]
ALICE3/Core/ConfigurationParser.cxx:84:12: warning: use starts_with instead of rfind [modernize-use-starts-ends-with]
ALICE3/Core/ConfigurationParser.cxx:95:5: warning: uninitialized record type: 'buffer' [cppcoreguidelines-pro-type-member-init]
ALICE3/Core/FlatTrackSmearer.cxx:174:25: warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
ALICE3/Core/GeometryContainer.cxx:44:8: warning: variable 'cleanLutWhenLoaded' is not initialized [cppcoreguidelines-init-variables]
ALICE3/Core/GeometryContainer.cxx:71:5: warning: do not use 'else' after 'return' [readability-else-after-return]
ALICE3/Core/GeometryContainer.cxx:93:5: warning: do not use 'else' after 'return' [readability-else-after-return]
ALICE3/Core/GeometryContainer.h:48:3: warning: function 'getConfigurations' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:49:3: warning: function 'getConfiguration' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:50:3: warning: function 'getLayerNames' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:51:3: warning: function 'hasValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:52:3: warning: function 'getValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:55:3: warning: function 'getFloatValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:56:3: warning: function 'getIntValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:81:3: warning: function 'getNumberOfConfigurations' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:82:3: warning: function 'getEntries' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:83:3: warning: function 'getEntry' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:84:3: warning: function 'getGeometryEntry' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:88:3: warning: function 'getConfigurations' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:89:3: warning: function 'getConfiguration' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:92:3: warning: function 'getValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
ALICE3/Core/GeometryContainer.h:93:3: warning: function 'getFloatValue' should be marked [[nodiscard]] [modernize-use-nodiscard]
++ [[ 8 -gt 0 ]]
++ exit 1
--
Hi Vit,
The merge was not forced against the CI; the configured check priority was respected, as recently restated by the analysis coordination
I agree with the decision to merge, since it was already known that the warnings would be addressed in a follow-up PR. This also avoids rerunning checks that have already passed.
Thanks for the comment and take care!
Hi Vit, The merge was not forced against the CI; the configured check priority was respected, as recently restated by the analysis coordination I agree with the decision to merge, since it was already known that the warnings would be addressed in a follow-up PR. This also avoids rerunning checks that have already passed. Thanks for the comment and take care!
The point of CI is to prevent new errors from getting merged in the upstream. This cannot work if there are pre-existing errors merged in the past.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use the TEnv parser in the Decayer without needing the entire GeometryContainer it's moved to its own class