Skip to content

[PWGUD] new two tracks table producer for global muon tracks - #18144

Merged
amatyja merged 2 commits into
AliceO2Group:masterfrom
rolavick:master
Oct 2, 2026
Merged

amatyja merged 2 commits into
AliceO2Group:masterfrom
rolavick:master

Conversation

@rolavick

@rolavick rolavick commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Pre-filter data into tables for local usage

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 5 disabled

@rolavick
rolavick marked this pull request as ready for review October 2, 2026 07:09
@rolavick
rolavick enabled auto-merge (squash) October 2, 2026 07:10
@alibuild

alibuild commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7787cd9 at 2026-10-02 09:20:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 83 warnings.'
Found 5 errors and 83 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/288d33fba71e7dba238eede7fd3689b098e27403/O2Physics-code-check/errors.txt
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:36:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:197:126: error: arithmetic between enumeration type '(anonymous namespace)::EventSelection' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:208:150: error: arithmetic between enumeration type '(anonymous namespace)::FwdTrackSelection' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:222:140: error: arithmetic between enumeration type '(anonymous namespace)::TruthTrouble' and floating-point type 'double' is deprecated [clang-diagnostic-deprecated-enum-float-conversion,-warnings-as-errors]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:255:22: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 83 -gt 0 ]]
++ cat /sw/BUILD/288d33fba71e7dba238eede7fd3689b098e27403/O2Physics-code-check/warnings.txt
PWGUD/DataModel/TwoFwdTracksEventTables.h:49:34: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:50:34: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:51:34: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:52:38: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:53:38: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:54:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:55:38: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:56:48: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:57:38: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:58:58: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:59:38: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:60:60: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:61:60: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:62:48: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:63:48: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:73:48: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:74:48: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:75:48: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:76:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:77:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:78:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/DataModel/TwoFwdTracksEventTables.h:79:54: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:103:35: warning: initializer for member 'amplitudesV0A' is redundant [readability-redundant-member-init]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:104:35: warning: initializer for member 'ampRelBCsV0A' is redundant [readability-redundant-member-init]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:109:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:110:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:111:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:112:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:113:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:114:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:115:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:116:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:117:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:118:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:119:3: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
[0 more errors; see full log]

Full log here.

amatyja
amatyja previously approved these changes Oct 2, 2026
@vkucera
vkucera disabled auto-merge October 2, 2026 09:38
@vkucera

vkucera commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

@rolavick Please fix the error before merging and please do not enable auto-merge if the PR has not been tested.

Comment thread PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx Outdated
@alibuild

alibuild commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 7787cd9 at 2026-10-02 11:57:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:197:126: error: arithmetic between enumeration type '{anonymous}::EventSelection' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:208:150: error: arithmetic between enumeration type '{anonymous}::FwdTrackSelection' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:222:140: error: arithmetic between enumeration type '{anonymous}::TruthTrouble' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 7787cd9 at 2026-10-02 12:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:197:126: error: arithmetic between enumeration type '{anonymous}::EventSelection' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:208:150: error: arithmetic between enumeration type '{anonymous}::FwdTrackSelection' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/TableProducer/twoFwdTracksEventTableProducer.cxx:222:140: error: arithmetic between enumeration type '{anonymous}::TruthTrouble' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

@amatyja
amatyja enabled auto-merge (squash) October 2, 2026 12:37
@amatyja
amatyja merged commit 8bce36d into AliceO2Group:master Oct 2, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants