Conversation
As far as I can tell this is always available.
Member
Author
|
@aldemeery you may want to have a look at this. |
aldemeery
reviewed
Sep 27, 2026
Comment on lines
+6
to
+13
| $subject = 'hello'; | ||
| $pattern = '/a(?C1)b(?C2)c/'; | ||
|
|
||
| var_dump(preg_match($pattern, $subject)); | ||
|
|
||
| ?> | ||
| --EXPECT-- | ||
| int(0) |
Contributor
There was a problem hiding this comment.
'hello' has no 'a' in it...and so, matching will never reach either callout point at all...which means int(0) does not really show that callouts are not supported, I guess it only shows the pattern compiles...or am I missing something here?
devnexen
reviewed
Sep 27, 2026
| } else { | ||
| pcre2_get_error_message(errnumber, error, sizeof(error)); | ||
| switch (errnumber) { | ||
| case PCRE2_ERROR_BACKSLASH_K_IN_LOOKAROUND: |
Member
There was a problem hiding this comment.
nit: you either need to guard it or update config0.m4 min. version check (was added for 10.38).
Member
Author
There was a problem hiding this comment.
Right, I might try and upgrade the minimal version to 10.40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed in order.