Skip to content

ext/intl: intl_error_set_custom_msg() crash without an active call fr… - #23673

Closed
devnexen wants to merge 1 commit into
php:PHP-8.5from
devnexen:intl_error_lifetime_fix
Closed

devnexen wants to merge 1 commit into
php:PHP-8.5from
devnexen:intl_error_lifetime_fix

Conversation

@devnexen

Copy link
Copy Markdown
Member

…ame.

Since 6600d0e the message was unconditionally prefixed with get_active_function_or_method_name(), which asserts zend_is_executing() and dereferences a null EG(current_execute_data) in a release build. A UConverter subclass destroyed at request shutdown reached it through ucnv_close(). Fall back to the unprefixed message when there is no frame.

…ame.

Since 6600d0e the message was unconditionally prefixed with
get_active_function_or_method_name(), which asserts zend_is_executing() and
dereferences a null EG(current_execute_data) in a release build. A UConverter
subclass destroyed at request shutdown reached it through ucnv_close(). Fall
back to the unprefixed message when there is no frame.
@devnexen
devnexen marked this pull request as ready for review September 12, 2026 11:05
@LamentXU123
LamentXU123 requested a review from Girgias September 12, 2026 14:32
@devnexen

Copy link
Copy Markdown
Member Author

ping :)

@LamentXU123 LamentXU123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot this fix. This looks correct to me.

@devnexen devnexen closed this in f61ebc0 Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants