Repository navigation
fix: Make default sort order nulls last - #1766
Conversation
|
Thanks! This is changing a public facing API so I think we need an entry in the upgrade guide. It's small, but it's important. |
Added. Btw I think the upgrade guide in the website is not being updated, 55.0.0 is currently missing: https://datafusion.apache.org/python/user-guide/upgrade-guides.html |
I think the website only updates when we do the release. You can see them on the staged site which comes off main: https://datafusion.staged.apache.org/python/user-guide/upgrade-guides.html |
Which issue does this PR close?
Closes #1765.
Rationale for this change
Make
sortfollow the same default as upstream (i.e., order nulls last).What changes are included in this PR?
nulls_firsttoFalse.Are there any user-facing changes?
df.sortwithout an explicitnulls_firstorders nulls last, similarly todf.sort_byand SQL'sORDER BY.