chore(claude): stop auto-enabling project MCP servers and drop Playwright MCP - #729
Open
neelay-aign wants to merge 2 commits into
Open
neelay-aign wants to merge 2 commits into
neelay-aign wants to merge 2 commits into
Conversation
… all Replaces enableAllProjectMcpServers with an explicit enabledMcpjsonServers list so a server added to .mcp.json later requires each developer's approval before it starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
neelay-aign
added
skip:test:long_running
neelay-aign
added
skip:test:long_running
Nothing in the repo uses it; developers who want it can add it at user scope. Ignoring .mcp.json keeps project MCP servers out of the repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
neelay-aign
changed the title
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableAllProjectMcpServers: truefrom.claude/settings.json. With it set, every server in.mcp.jsonstarted on developer machines without a prompt, including any server added later by a PR. Without it, Claude Code asks each developer before starting a project server..mcp.json. Its only entry was the Playwright MCP server added in chore: add Playwright MCP server config to .mcp.json [PYSDK-117] #608. Nothing in the repo uses that server (no tests, skills, docs or CI), and it ran@playwright/mcp@latest, so each start pulled whatever version was newest on npm..mcp.jsonback to.gitignore, as it was before chore: add Playwright MCP server config to .mcp.json [PYSDK-117] #608. A shared project MCP server now has to be added deliberately.To keep using Playwright MCP, add it at user scope:
Follow-up (not in this PR)
~/.claude/settings.jsonand.claude/settings.local.jsonforenableAllProjectMcpServers, because a repo review can't see those files.Test plan
.claude/settings.jsonis still valid JSON/mcplists no project-scoped servers🤖 Generated with Claude Code